Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.13] bpf: EgressGW-related tracing improvements #27526

Merged
merged 2 commits into from Aug 21, 2023
Merged

[v1.13] bpf: EgressGW-related tracing improvements #27526

merged 2 commits into from Aug 21, 2023

Conversation

julianwiedmann
Copy link
Member

Manual backport (the first patch needed a re-implementation) of

Once this PR is merged, you can update the PR labels via:

for pr in 27178 27218; do contrib/backporting/set-labels.py $pr done 1.13; done

or with

make add-labels BRANCH=v1.13 ISSUES=27178,27218

@julianwiedmann
bpf: nat: enable CT-driven trace aggregation
3c8c6b4 
[ upstream commit 3796d0d ]

[ backporter's notes: this is pretty much a re-implementation. ]

When the NAT code creates a CT entry for a SNATed connection (for instance
for EgressGW traffic), pass back the resulting trace information to
tail_handle_snat_fwd_ipv*().

Note that this also wires up the path from tail_nodeport_nat_egress_ipv*(),
but those connections never require CT on the NAT level.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: egressgw: set trace reason for reply traffic
164f7cd 
[ upstream commit f4098db ]

When redirecting EgressGW replies to the tunnel interface, we don't have a
CT lookup to determine the trace reason. But we still know it's a reply, so
we can set the reason manually.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Aug 16, 2023
@julianwiedmann
Copy link
Member Author

/test-backport-1.13

@julianwiedmann
Copy link
Member Author

/test-runtime

@julianwiedmann julianwiedmann marked this pull request as ready for review August 18, 2023 09:00
@julianwiedmann julianwiedmann requested a review from a team as a code owner August 18, 2023 09:00
@julianwiedmann julianwiedmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 21, 2023
@joestringer joestringer merged commit 35230f5 into cilium:v1.13 Aug 21, 2023
60 checks passed
@julianwiedmann julianwiedmann deleted the v1.13-bpf-tracing branch August 21, 2023 16:34
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julianwiedmann @gentoo-root @joestringer