egressgw: small test fixes #27574
Merged
egressgw: small test fixes #27574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EGRESS_POLICY_MAP is only defined if the egress gateway is enabled. Allow including egressgw.h even if that is not the case, so that the helpers can be reused. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
When an egressgw BPF unit test fails it helpfully dumps any cilium debug messages with the test. The messages often contain port numbers which can be used to infer which subtest generated them. Make it easier to go from port number to subtest by accounting for endiannness in client_port(). Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Use the correct test enum in tc_egressgw_skip_excluded_cidr_redirect to avoid tests interfering with each other. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Always clear the exclude CIDR rule, regardless of whether the test succeeds or not. Otherwise subsequent tests will fail due to the presence of the exclude rule. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
lmb
added
release-note/misc
|
/test |
aspsk
approved these changes
Aug 18, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
the
needs-backport/1.14
jibi
added
backport-pending/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpf, egressgw: gate use of EGRESS_POLICY_MAP on define
bpf, egressgw: make it easier to correlate test cases with debug msg
bpf, egressgw: fix tc_egressgw_skip_excluded_cidr_redirect case
bpf, egressgw: always clear excluded cidr at end of snat test