Fix a bug where cilium host IP is not read from k8s node annotations #27590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
cc @christarazi / @aanm |
joestringer
added
release-note/bug
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
I think this sound reasonable to me. I am a bit surprised that's not the case today actually. |
2 tasks
aanm
added
needs-backport/1.13
|
/test |
After cilium@0696874 refactored the logic to read annotations and change the default behavior, addrs array was never assigned to newNode.IPAddresses after it was populated. Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
hemanthmalla
force-pushed
the
hmalla/router_annotation
branch
from
d468bfa
to
7826222
Compare
|
/test |
tklauser
added
backport-pending/1.13
tklauser
added
backport-pending/1.14
joestringer
added
backport-done/1.13
This was referenced Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 0696874 refactored the logic to read annotations and change the default behavior, addrs array was never assigned to newNode.IPAddresses after it was populated.
Fixes: #27439 partly, there seem to be a race between when
n.localNode.IPAddressesis populated and when the first ciliumnode(CN) update is made after an agent restart. In our fork we temporarily added a behavior to retain host IP from ciliumnode when localNode hasn't yet been populated to avoid the double writes. This isn't perfect because in the rare event wherecilium_host's router IP has been removed, it would not be updated on the CN.Open Questions :
Thanks to @jaredledvina for identifying the duplicate writes