Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach TC programs using bpf_link tcx instead of netlink #27632

Closed
ti-mo opened this issue Aug 22, 2023 · 1 comment · Fixed by #30103
Closed

Attach TC programs using bpf_link tcx instead of netlink #27632

ti-mo opened this issue Aug 22, 2023 · 1 comment · Fixed by #30103
Assignees
@rgo3
Labels
kind/enhancement This would improve or streamline existing functionality. pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/loader Impacts the loading of BPF programs into the kernel.

Comments

@ti-mo
Copy link
Contributor

ti-mo commented Aug 22, 2023

Depends on cilium/ebpf#1117.

This issue is for replacing the current tc filter creation and attachment logic with a tcx-based API.

Design TBD since the ebpf-go API hasn't been written, but we could pin links at /sys/fs/bpf/cilium/{endpoints||tcx}/lxcXYZ/{ingress,egress}.
@ti-mo ti-mo added sig/loader Impacts the loading of BPF programs into the kernel. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Aug 22, 2023
@julianwiedmann julianwiedmann added the kind/enhancement This would improve or streamline existing functionality. label Sep 12, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Nov 13, 2023
@lmb lmb added pinned These issues are not marked stale by our issue bot. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Nov 17, 2023
@rgo3 rgo3 self-assigned this Nov 24, 2023
@msherif1234 msherif1234 mentioned this issue Nov 27, 2023
Closed
@ti-mo ti-mo mentioned this issue Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgo3 rgo3

Labels
kind/enhancement This would improve or streamline existing functionality. pinned These issues are not marked stale by our issue bot. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

loader: attach programs using tcx rgo3/cilium
4 participants
@lmb @ti-mo @rgo3 @julianwiedmann