[v1.13] bpf: nat: report detailed error from map_update_elem() for NAT entries #27652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 1f6c10d ] [ backporter's notes: as cilium#24716 is missing, manually add the needed ext_err bits into nat.h and switch the callers to send_drop_notify_error_ext(). ] snat_*_nat_handle_mapping() already takes an *ext_err parameter to pass up detailed error information from its CT logic. Use this to also report errors from map_update_elem() when creating the NAT entries. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
[ upstream commit 66e9579 ] [ backporter's notes: as cilium#24716 is missing, do the switch to send_drop_notify_error_ext() ] tail_nodeport_dsr_ingress_ipv*() already maintains an *ext_err parameter to report detailed error information from its CT logic. Use this to also report errors from map_update_elem() when creating the RevDNAT entry. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
maintainer-s-little-helper
bot
added
backport/1.13
julianwiedmann
changed the title
|
/test-backport-1.13 |
|
/test-1.26-net-next |
gentoo-root
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
#24716 is missing from v1.13 and way too intrusive to backport.
Those ext_errs would be also useful, it's a pity it wasn't straightforward to backport...
Yep, I had initially hoped to get them in as well. But it was too many conflicts piling up :/. Maybe it works better with a clean re-implementation, not trying to resolve the conflicts 1-by-1. |
julianwiedmann
added
the
ready-to-merge
joestringer
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport, as #24716 is missing from
v1.13and way too intrusive to backport.Once this PR is merged, you can update the PR labels via:
or with