Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: the clustermesh secret name #27658

Merged
merged 1 commit into from Aug 24, 2023
Merged

Conversation

weizhoublue
Copy link
Contributor

when debugged the clustermesh, I found typos

[root@master10 ~]# kubectl get secret -n kube-system clustermesh-apiserver-admin-certs
Error from server (NotFound): secrets "clustermesh-apiserver-admin-certs" not found

[root@master10 ~]# kubectl get secret -n kube-system clustermesh-apiserver-admin-cert
NAME                               TYPE                DATA   AGE
clustermesh-apiserver-admin-cert   kubernetes.io/tls   3      28h

the chart code

apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: clustermesh-apiserver-client-cert
  namespace: {{ .Release.Namespace }}
spec:
  issuerRef:
    {{- toYaml .Values.clustermesh.apiserver.tls.auto.certManagerIssuerRef | nindent 4 }}
  secretName: clustermesh-apiserver-client-cert
  commonName: externalworkload
  duration: {{ printf "%dh0m0s" (mul .Values.clustermesh.apiserver.tls.auto.certValidityDuration 24) }}
{{- end }}
---
apiVersion: v1
kind: Secret
metadata:
  name: clustermesh-apiserver-admin-cert
  namespace: {{ .Release.Namespace }}
type: kubernetes.io/tls
data:
  ca.crt:  {{ .commonCA.Cert | b64enc }}
  tls.crt: {{ $cert.Cert | b64enc }}
  tls.key: {{ $cert.Key  | b64enc }}
{{- end }}

Signed-off-by: weizhou.lan@daocloud.io <weizhou.lan@daocloud.io>
@weizhoublue weizhoublue requested a review from a team as a code owner August 23, 2023 13:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 23, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 23, 2023
@weizhoublue weizhoublue changed the title doc: typo of the mesh secret name typo: the clustermesh secret name Aug 23, 2023
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@borkmann borkmann added the release-note/misc This PR makes changes that have no direct user impact. label Aug 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 24, 2023
@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 24, 2023
@borkmann borkmann merged commit dcef00d into cilium:main Aug 24, 2023
41 checks passed
@borkmann borkmann added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Aug 24, 2023
@pippolo84 pippolo84 mentioned this pull request Aug 28, 2023
9 tasks
@pippolo84 pippolo84 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 28, 2023
@michi-covalent michi-covalent added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants