tests-smoke.yaml doesn't properly validate metrics using promtool

[joestringer]

PR #27645 only changes .github/workflows/push-chart-ci.yaml. However, CI failed in this way for the PR:

https://github.com/cilium/cilium/actions/runs/5951467101/job/16141353424?pr=27645

...
prometheus-2.34.0.linux-amd64/promtool
cilium_statedb_table_delete_trackers_total non-counter metrics should not have "_total" suffix
Error: Process completed with exit code 3.

The PR doesn't touch this file, and yet somehow this job failed.

The job is also passing on main branch:
https://github.com/cilium/cilium/actions/workflows/tests-smoke.yaml?query=branch%3Amain

Seems like the underlying issue was introduced in commit 6f676a3 / #27160, but it doesn't look like the test failed for that PR.

[joestringer]

The direct problem (CI failing due to misnamed metric) might have been resolved by #27657 , just because tests-smoke.yaml doesn't enable all the metrics and the related metric is now disabled by default. But the metric name is still wrong and that step was evidently not caught when introducing the metric for whatever reason.

[github-actions]

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

[github-actions]

This issue has not seen any activity since it was marked stale.
Closing.