Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KVStoreMesh metric's ConfigName #27680

Merged
merged 2 commits into from Sep 29, 2023
Merged

Fix KVStoreMesh metric's ConfigName #27680

merged 2 commits into from Sep 29, 2023

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Aug 24, 2023

Description in commit messages.

Fixes name used for disabling KVStoreMesh metrics.

@marseel marseel requested review from a team as code owners August 24, 2023 10:51
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 24, 2023
@marseel marseel added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Aug 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 24, 2023
@marseel
Copy link
Contributor Author

marseel commented Aug 24, 2023

/test

giorio94
giorio94 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marseel
Copy link
Contributor Author

marseel commented Sep 7, 2023

/test

@marseel
Generate metric's ConfigName based on other metric's parameters.
b3c99b6 
In most of the cases, ConfigName provided in metrics option is just
joined Namespace, Subsystem and Name so there is no need to provide it
in most of the cases.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel
Fix ConfigName for KVStoreMesh metrics.
92e0c68 
Previously, ConfigName for common Clustermesh metrics was dynamically
generated. However, in KVStoreMesh case, subsystem was set to empty string,
which cause metric to have incorrect ConfigName in format of "Namespace__metric_name".

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel
Copy link
Contributor Author

marseel commented Sep 28, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 28, 2023
@aanm aanm merged commit cf7a63f into cilium:main Sep 29, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

@giorio94 giorio94 giorio94 approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marseel @tommyp1ckles @jrajahalme @giorio94 @aanm