clean-up: remove check for permissive CCNPs #27690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
joestringer
reviewed
Aug 25, 2023
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aanm
approved these changes
Aug 25, 2023
|
/test |
This check was designed to inform users of CCNP that the behaviour changed around the timeframe of v1.9. However, the actual check is complaining about policy that is valid. At this point there is no need to warn users during preflight checks that they are using empty endpoint selectors in CCNPs, because this can validly be used to select all Pods within the cluster. Remove the check. Signed-off-by: sh2 <shawnhxh@outlook.com> Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
remove-permissive-ccnps-check
branch
from
68f9500
to
ca1a642
Compare
|
I rebased & squashed the commits together and provided more context in the commit message. Running CI now. If that passes, this PR should be good to merge. |
joestringer
added
the
needs-backport/1.14
|
I think that this could benefit users upgrading to v1.14, since it's currently causing preflight checks to fail for valid policy statements. I expect low risk for backporting. Marked for backport to v1.14. |
|
/test |
pippolo84
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.2
michi-covalent
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
This check was designed to inform users of CCNP that the behaviour
changed around the timeframe of v1.9. However, the actual check is
complaining about policy that is valid. At this point there is no need
to warn users during preflight checks that they are using empty endpoint
selectors in CCNPs, because this can validly be used to select all Pods
within the cluster. Remove the check.
Fixes: #27689