Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "make fsnotify event more readable" #27694

Merged
merged 1 commit into from Aug 25, 2023
Merged

Revert "make fsnotify event more readable" #27694

merged 1 commit into from Aug 25, 2023

Conversation

jschwinger233
Copy link
Member

This reverts commit 479fb7d.

The code changes are not equivalent. For example, event.Op=fsnotify.Create has different results.

Fixes: #22903

Fixes a issue that IPsec key rotation can't be triggered.

Signed-off-by: Zhichuan Liang gray.liang@isovalent.com

@jschwinger233
Revert "make fsnotify event more readable"
14fe010 
This reverts commit 479fb7d.

The code changes are not equivalent. For example,
event.Op=fsnotify.Create has different results.

Fixes: cilium#22903

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 25, 2023
@jschwinger233 jschwinger233 added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Aug 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 25, 2023
@jschwinger233 jschwinger233 added area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Aug 25, 2023
@jschwinger233
Copy link
Member Author

/test

@jschwinger233 jschwinger233 marked this pull request as ready for review August 25, 2023 08:59
@jschwinger233 jschwinger233 requested a review from a team as a code owner August 25, 2023 08:59
@julianwiedmann julianwiedmann added kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.2 Aug 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 25, 2023
@pchaigno pchaigno merged commit d86c148 into cilium:main Aug 25, 2023
61 checks passed
@pchaigno pchaigno mentioned this pull request Aug 25, 2023
Merged
@pippolo84 pippolo84 mentioned this pull request Aug 28, 2023
Merged
9 tasks
@pippolo84 pippolo84 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.2 Aug 28, 2023
@michi-covalent michi-covalent added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.2 Sep 9, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

@pchaigno pchaigno pchaigno approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

Assignees
No one assigned
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.14.2
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jschwinger233 @gentoo-root @pchaigno @julianwiedmann @pippolo84 @michi-covalent