New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GatewayAPI: Fix listener parsing #27695
Conversation
Hi @Managarmrr , thanks for the contribution. I can't speak for the details, will leave review up to the assigned CODEOWNERS. But I will point out one thing - Cilium relies on linear git history, so before accepting this PR the merge commit will need to be dropped. Consider either rebasing against tip of main + force pushing the PR to update, or use the drop-down from "update branch" at the bottom of the page to do a rebase against the main branch. I've kicked off the initial testsuites to give CI feedback for now. |
/test |
Previously, parsing the listeners of a Gateway object only worked correctly, if only one listener of a given type (HTTP or TLS) was present, as looping over them was incorrectly handled. Fixes: cilium#27533 Fixes: 677e8b4 ("Implement TLSRoute") Signed-off-by: Patrick Reich <patrick@neodyme.io>
94638a4
to
3c05c8d
Compare
Thanks for the heads up, for some reson I expected GitHub to perform a rebase on main when I pressed that button. Fixed it now. |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! LGTM, thanks :)
(sorry for the label remove and add, pressed the wrong buttons i trust on the bot here) |
Previously, parsing the listeners of a Gateway object only worked correctly, if only one listener of a given type (HTTP or TLS) was present, as looping over them was incorrectly handled.
Fixes: #27533
Fixes: 677e8b4 ("Implement TLSRoute")