Auth map GC on Endpoint delete #27697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
meyskens
force-pushed
the
meyskens/auth-ep-gc
branch
from
472addd
to
e14a707
Compare
meyskens
added
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
meyskens
force-pushed
the
meyskens/auth-ep-gc
branch
from
e14a707
to
c4c0c18
Compare
meyskens
force-pushed
the
meyskens/auth-ep-gc
branch
from
c4c0c18
to
ca92dbc
Compare
youngnick
reviewed
Oct 4, 2023
meyskens
force-pushed
the
meyskens/auth-ep-gc
branch
from
ca92dbc
to
f24b7d5
Compare
|
/test |
youngnick
approved these changes
Oct 12, 2023
This change will trigger a endpoint list based auth map garbage collection on a delete call from the endpoint manager. This ensures instant deletion of an auth map entry if an endpoint gets deleted that was the last of a given security id. Some of this is already done with the policy map GC. This change adds an additional safeguard to it and does it on a delete event where the policy map only runs on scheduled intervals. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/auth-ep-gc
branch
from
8171975
to
a50f9f5
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will trigger a endpoint list based auth map garbage collection on a delete call from the endpoint manager. This ensures instant deletion of an auth map entry if an endpoint gets deleted that was the last of a given security id.
Some of this is already done with the policy map GC. This change adds an aditional safeguard to it and does it on a delete event where the policy map only runs on scheduled intervals.