helm: fix envoy daemonset loglevel with multiple verbose debug groups #27698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/bug
|
/test |
mhofstetter
added
the
needs-backport/1.14
Currently, the Envoy DaemonSet loglevel is not set correctly if multiple verbose debug groups are passed as helm values. Comma is used as group separator instead of a space. (Got confused because Go Viper flags are separated by a comma.) This commit fixes this by changing the separator. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-fix-loglevel-multiple-verbose
branch
from
0e65976
to
74d93b8
Compare
|
rebased to |
|
/test |
nebril
approved these changes
Aug 28, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
mhofstetter
deleted the
pr/mhofstetter/envoy-fix-loglevel-multiple-verbose
branch
jibi
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.2
jibi
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Envoy DaemonSet loglevel is not set correctly if multiple verbose debug groups are passed as helm values.
->
Unknown verbose debug group: <...>in Cilium Agent logThe problem is that the comma is used as group separator instead of a space. (Got confused because Go Viper flags are separated by a comma.)
This commit fixes this by changing the separator.