ipam: when a CiliumNode is removed, delete node label from metrics. #27713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
tommyp1ckles
added
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
christarazi
added
sig/ipam
christarazi
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
TIL about DeleteLabelValues. I thought it wasn't possible. Thanks for the fix.
A few CI failures around build. Also, it would be good to put a Fixes tag for the commit that this PR is fixing so we know where to backport this to. I'm pretty sure it's only for 1.14 so I've added that already.
tommyp1ckles
force-pushed
the
pr/tp/fix-operator-ipam-target-node-metrics-on-delete
branch
2 times, most recently
from
e195ff4
to
4f2c3dd
Compare
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/fix-operator-ipam-target-node-metrics-on-delete
branch
2 times, most recently
from
0088d79
to
1aeacb9
Compare
|
/test |
Affects: * operator_ipam_available_ips * operator_ipam_used_ips * operator_ipam_needed_ips Which have the label "target_name", previously when a Node was deleted the metric continued to be emitted by the Prometheus exporter, leading to confusing sum() values across a cluster. Fixes changes in cilium#24776 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/fix-operator-ipam-target-node-metrics-on-delete
branch
from
1aeacb9
to
c536bc1
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.2
jibi
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affects:
Which have the label "target_name", previously when a Node was deleted the metric continued to be emitted by the Prometheus exporter, leading to confusing sum() values across a cluster.