Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-e2e: Add secondary network NodePort tests #27738

Merged
merged 2 commits into from Sep 1, 2023
Merged

ci-e2e: Add secondary network NodePort tests #27738

merged 2 commits into from Sep 1, 2023

Conversation

brb
Copy link
Member

@brb brb commented Aug 28, 2023 •
edited

@brb brb added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Aug 28, 2023
@brb
Copy link
Member Author

brb commented Aug 28, 2023

/ci-e2e

@brb brb mentioned this pull request Aug 28, 2023
Merged
@brb
Copy link
Member Author

brb commented Aug 29, 2023

/ci-e2e

@brb brb force-pushed the pr/brb/ci-e2e-secondary-nodeport-bpf branch from 471ef95 to 164d148 Compare August 29, 2023 10:07
@brb
Copy link
Member Author

brb commented Aug 29, 2023

/ci-e2e

@brb brb force-pushed the pr/brb/ci-e2e-secondary-nodeport-bpf branch 2 times, most recently from bc4f5be to 14cd52b Compare August 31, 2023 12:42
@brb
Copy link
Member Author

brb commented Aug 31, 2023

/ci-e2e

@brb brb force-pushed the pr/brb/ci-e2e-secondary-nodeport-bpf branch from 14cd52b to 21205bc Compare September 1, 2023 07:56
@brb
Copy link
Member Author

brb commented Sep 1, 2023

/ci-e2e

@brb brb added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.7 Sep 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.2 Sep 1, 2023
@brb
ci-e2e: Add secondary network
01e988e 
This will enable secondary NodePort tests [1].

[1]: cilium/cilium-cli#1942

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
ginkgo: Remove Tests with secondary NodePort device
e13b3fb 
Replaced by the tests in the previous commit.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/ci-e2e-secondary-nodeport-bpf branch from 21205bc to e13b3fb Compare September 1, 2023 08:23
@brb
Copy link
Member Author

brb commented Sep 1, 2023

/test

@brb brb marked this pull request as ready for review September 1, 2023 08:23
@brb brb requested review from a team as code owners September 1, 2023 08:23
@aanm aanm self-requested a review September 1, 2023 09:04
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 1, 2023
@borkmann borkmann merged commit 2bd2a36 into main Sep 1, 2023
197 of 199 checks passed
@borkmann borkmann deleted the pr/brb/ci-e2e-secondary-nodeport-bpf branch September 1, 2023 14:02
@jibi jibi mentioned this pull request Sep 4, 2023
Merged
16 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 4, 2023
@jibi jibi mentioned this pull request Sep 4, 2023
Merged
10 tasks
@jibi jibi added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Sep 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.2 Sep 5, 2023
@jibi jibi added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 7, 2023
@michi-covalent michi-covalent moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.2 Sep 9, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
@michi-covalent michi-covalent added this to Needs backport from main in 1.13.8 Sep 9, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.13.7 Sep 9, 2023
@gandro gandro mentioned this pull request Sep 12, 2023
Merged
6 tasks
@gandro gandro added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Sep 12, 2023
@brb brb removed the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Sep 12, 2023
@jrajahalme jrajahalme added this to Needs backport from main in 1.13.9 Oct 17, 2023
@jrajahalme jrajahalme removed this from Needs backport from main in 1.13.8 Oct 17, 2023
@jrajahalme jrajahalme removed this from Needs backport from main in 1.13.9 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@aanm aanm aanm approved these changes

@ysksuzuki ysksuzuki Awaiting requested review from ysksuzuki ysksuzuki is a code owner automatically assigned from cilium/sig-lb

@christarazi christarazi Awaiting requested review from christarazi christarazi is a code owner automatically assigned from cilium/ci-structure

@qmonnet qmonnet Awaiting requested review from qmonnet qmonnet was automatically assigned from cilium/contributing

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.14.2
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brb @borkmann @nbusseneau @aanm @gandro @jibi