Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/policy: Convert benchmarks in resolve_test.go to std benchmarks #27815

Merged
merged 1 commit into from Aug 31, 2023
Merged

pkg/policy: Convert benchmarks in resolve_test.go to std benchmarks #27815

merged 1 commit into from Aug 31, 2023

Conversation

christarazi
Copy link
Member

With checkmate, it seems to hide the benchmark results. When converting
the benchmarks to the standard benchmark style, the results show again.

Given we will eventually convert all checkmate usages to the standard
style, we might as well make the change permanent via this commit.

Signed-off-by: Chris Tarazi chris@isovalent.com

@christarazi
pkg/policy: Convert benchmarks in resolve_test.go to std benchmarks
ee2f1b8 
With checkmate, it seems to hide the benchmark results. When converting
the benchmarks to the standard benchmark style, the results show again.

Given we will eventually convert all checkmate usages to the standard
style, we might as well make the change permanent via this commit.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi added kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. release-note/misc This PR makes changes that have no direct user impact. labels Aug 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 30, 2023
@christarazi christarazi marked this pull request as ready for review August 30, 2023 21:18
@christarazi christarazi requested a review from a team as a code owner August 30, 2023 21:18
@christarazi
Copy link
Member Author

christarazi commented Aug 30, 2023 •
edited

/test

Edit: integration-test hit #27837

@christarazi christarazi mentioned this pull request Aug 31, 2023
Closed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 31, 2023
@christarazi christarazi merged commit ecdf5a5 into cilium:main Aug 31, 2023
61 checks passed
@christarazi christarazi deleted the pr/christarazi/policy-convert-benchmark branch August 31, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christarazi @nathanjsweet