Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ariane trigger phrases #27822

Merged
merged 3 commits into from Aug 30, 2023
Merged

Add missing ariane trigger phrases #27822

merged 3 commits into from Aug 30, 2023

Conversation

tklauser
Copy link
Member

Currently, the integration and runtime tests cannot be triggered separately via ariane. Add the missing trigger phrases. Also add the missing trigger phrase to the conformance ingress workflow name. See commits for details.

@tklauser
ariane: add trigger command for runtime tests
a3c7b55 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
ariane: add trigger phrase for integration tests
f773050 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
.github/workflows: add trigger phrase to conformance ingress workflow…
6775fce 
… name

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Aug 30, 2023
@tklauser tklauser requested review from a team as code owners August 30, 2023 09:43
@tklauser tklauser added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Aug 30, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.2 Aug 30, 2023
viktor-kurchenko
viktor-kurchenko approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tklauser
Copy link
Member Author

/test

@tklauser
Copy link
Member Author

I guess we'll need to adjust the required workflows on the repo once this PR is merged. The following workflows are renamed to contain their trigger phrase:

  • Conformance Ingress -> Conformance Ingress (ci-ingress)
  • Conformance Runtime -> Conformance Runtime (ci-runtime)
  • Integration Tests -> Integration Tests (ci-integration)

Sorry about that 😞

/cc @aanm @joestringer

@aanm aanm merged commit d91c819 into main Aug 30, 2023
200 checks passed
@aanm aanm deleted the pr/tklauser/ariane-trigger-runtime branch August 30, 2023 12:27
@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Aug 30, 2023
@jibi jibi mentioned this pull request Sep 4, 2023
Merged
16 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.14 in 1.14.2 Sep 7, 2023
@michi-covalent
Copy link
Contributor

should we backport this to v1.13 and v1.12 branches? either that or we need to update branch protection rules for v1.13 and v1.12. right now Conformance Ingress (ci-ingress) is getting stuck: #27980

@michi-covalent michi-covalent mentioned this pull request Sep 7, 2023
Merged
4 tasks
@qmonnet qmonnet mentioned this pull request Sep 7, 2023
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.12 in 1.12.14 Sep 8, 2023
@nbusseneau
Copy link
Member

nbusseneau commented Sep 8, 2023 •
edited

For backports that require changes to the PR checks, I highly recommend to use the backport/author label so that the author can make sure to check the checks on stable branches as well (because sometimes they're different / not here, and the author has of course the most context). @tklauser I am adding the label, please let me know if that's not good for you.

@nbusseneau nbusseneau added backport/author The backport will be carried out by the author of the PR. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Sep 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.7 Sep 8, 2023
@qmonnet qmonnet added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Sep 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.14 Sep 8, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
@michi-covalent michi-covalent added this to Needs backport from main in 1.13.8 Sep 9, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.13.7 Sep 9, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
@tklauser
Copy link
Member Author

tklauser commented Sep 12, 2023 •
edited

For backports that require changes to the PR checks, I highly recommend to use the backport/author label so that the author can make sure to check the checks on stable branches as well (because sometimes they're different / not here, and the author has of course the most context). @tklauser I am adding the label, please let me know if that's not good for you.

Sounds good to me. Looks like it was already taken care of for v1.12 and v1.14. I'll take care of the backport to v1.13.

@tklauser tklauser mentioned this pull request Sep 12, 2023
Merged
@jrajahalme jrajahalme mentioned this pull request Oct 17, 2023
Merged
@julianwiedmann julianwiedmann added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport/author The backport will be carried out by the author of the PR. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.12.14
Backport done to v1.12
1.13.8
Needs backport from main
1.14.2
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tklauser @michi-covalent @nbusseneau @qmonnet @viktor-kurchenko @jibi @aanm @julianwiedmann