Fix propagation of namespace labels to CEP labels #27831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
kind/bug
|
/test |
2 tasks
tklauser
force-pushed
the
pr/tklauser/cep-namespace-labels-sync
branch
from
c2c5901
to
dd2a6d4
Compare
…esInit The default value of an atomic.Bool is already false. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Avoid under- or overallocating the map and thus increasing memory pressure. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/cep-namespace-labels-sync
branch
from
dd2a6d4
to
ff76eb8
Compare
|
/test |
Currently (*namespaceUpdater).oldLabels is never updated with the namespace's labels after they have been synced to endpoints. This can e.g. lead to updates mistakenly being skipped. This in turn can lead to situations as described in #27626 where namespace derived labels are not removed from CEPs when the corresponding label is removed from the namespace. Fix this by always updating (*namespaceUpdater).oldLabels on successful endpoint label update. Fixes: 83391b4 ("pkg/k8s: ignore namespace events that do not change labels") Signed-off-by: Tobias Klauser <tobias@cilium.io>
christarazi
approved these changes
Aug 30, 2023
This avoids unnecessarily filtering old labels on successive calls to (*namespaceUpdater).update. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/cep-namespace-labels-sync
branch
from
ff76eb8
to
45f13a1
Compare
|
Force pushed to fix a linter warning about unnecessary assignment to |
|
/test |
tklauser
added
the
ready-to-merge
jibi
added
backport-pending/1.14
This was referenced Sep 4, 2023
tklauser
removed
needs-backport/1.11
needs-backport/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.2
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.2
jibi
added
backport-done/1.14
michi-covalent
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
(*namespaceUpdater).oldLabelsis never updated with the namespace's labels after they have been synced to endpoints. This can e.g. lead to updates mistakenly being skipped. This in turn can lead to situations as described in #27626 where namespace derived labels are not removed from CEPs when the corresponding label is removed from the namespace.Fix this by always updating
(*namespaceUpdater).oldLabelson successful endpoint label update.Review by commit: The first two commits are preparatory cleanups. The third commit is the actual bug fix. The fourth commit is a small optimization.
Fixes: #27626