Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schenker to the user list #27833

Merged
merged 1 commit into from Sep 6, 2023
Merged

Conversation

amirkkn
Copy link

@amirkkn amirkkn commented Aug 30, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@amirkkn amirkkn requested a review from a team as a code owner August 30, 2023 18:29
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 30, 2023
@maintainer-s-little-helper
Copy link

Commit de7f8624368652982fe5738160943e15aade6b8c does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 30, 2023
@amirkkn amirkkn changed the title Add Schenker in user list Add Schenker to user list Aug 30, 2023
@amirkkn amirkkn changed the title Add Schenker to user list Add Schenker to the user list Aug 30, 2023
@xmulligan xmulligan added the release-note/misc This PR makes changes that have no direct user impact. label Sep 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 4, 2023
@xmulligan
Copy link
Member

Thanks for the addition @amirkkn !

Would you mind signing off your commit so we can merge it? https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#dev-coo

Signed-off-by: Amir Kheirkhahan <amir.kheirkhahan@dbschenker.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 4, 2023
@amirkkn
Copy link
Author

amirkkn commented Sep 4, 2023

Updated! Thanks @xmulligan

@xmulligan
Copy link
Member

Thanks! Looks good to me now

@xmulligan xmulligan added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 4, 2023
@youngnick
Copy link
Contributor

Skipping CI because docs update.

@youngnick youngnick merged commit 25be098 into cilium:main Sep 6, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants