images: Support updating Envoy to PR images #27850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
kind/enhancement
mhofstetter
approved these changes
Sep 1, 2023
jrajahalme
force-pushed
the
images-update-envoy-with-prs
branch
from
16922b5
to
466bf36
Compare
Update Envoy to PR build image when $proxy_branch is set to the PR branch name, e.g.: $ proxy_branch=pr/my/branch images/scripts/update-cilium-envoy-image.sh This will result in the image being pulled from cilium-envoy-dev instead of cilium-envoy and the tag consisting only of the Git commit SHA (no Envoy version prefix). sed line for Dockerfile update needs to be more explicit so that the image repo name can be updated both ways. The github repo can also be overridden, with `proxy_repo=my/repo` (default is `cilium/proxy`). Note that this still only supports PR build by the main repo as otherwise the image would not be available in quay.io/cilium/cilium-envoy-dev. Error out if sha256 digest for the image is not (yet) available, rather than continuing with an empty digest, as we still have "use digest" configured. Also fix the recommended build order as install/kubernetes has to be built before Documentation. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
images-update-envoy-with-prs
branch
from
466bf36
to
6506f2d
Compare
|
/test |
jibi
approved these changes
Sep 12, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Envoy to PR build image when $proxy_branch is set to the PR branch name, e.g.:
$ proxy_branch=pr/my/branch images/scripts/update-cilium-envoy-image.sh
This will result in the image being pulled from cilium-envoy-dev instead of cilium-envoy and the tag consisting only of the Git commit SHA (no Envoy version prefix). sed line for Dockerfile update needs to be more explicit so that the image repo name can be updated both ways.
The github repo can also be overridden, with
proxy_repo=my/repo(default iscilium/proxy). Note that this still only supports PRs build by the main repo as otherwise the image would not be available in quay.io/cilium/cilium-envoy-dev.Error out if sha256 digest for the image is not (yet) available, rather than continuing with an empty digest, as we still have "use digest" configured.
Also fix the recommended build order as install/kubernetes has to be built before Documentation.