examples: Fix YAML error backendRefs in HTTP Header Modifier #27871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 34cd9a88c82755bf24c6135f1b953a96b90ff6ad does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
github-actions
bot
added
the
kind/community-contribution
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
Hi @nvibert , I did the setup step by step as you wrote, just found one mirror typo issue. Have time to review my change ? ;-) |
haiyuewa
changed the title
Let me check 👍 |
|
Yep, @haiyuewa - you're absolutely correct. Well spotted ! I don't have reviewers rights but if I had, I would approve it 😅 |
nathanjsweet
approved these changes
Sep 14, 2023
The use case "HTTP Header Modifier" has wrong 'backendRefs' service name:
$kubectl describe HTTPRoute header-http-echo
Message: Service "echo" not found
Observed Generation: 1
Reason: BackendNotFound
Status: False
The right service name should be "echo-1", which has port number 8080:
$kubectl describe HTTPRoute header-http-echo
Message: Service reference is valid
Observed Generation: 1
Reason: ResolvedRefs
Status: True
Type: ResolvedRefs
Fixes: bb50725 ("Header Modifier and Splitting use cases")
Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
|
/test |
ldelossa
added
the
release-note/bug
maintainer-s-little-helper
bot
added
ready-to-merge
|
thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit bb50725 ("Header Modifier and Splitting use cases") used wrong 'backendRefs' service name setting for Header Modifier HTTPRoute.
kubectl describe HTTPRoute header-http-echo
Message: Service "echo" not found
Observed Generation: 1
Reason: BackendNotFound
Status: False
The demo has two services: "echo-1" with 8080, "echo-2" with 8090. Fix the wrong name:
kubectl describe HTTPRoute header-http-echo
Message: Service reference is valid
Observed Generation: 1
Reason: ResolvedRefs
Status: True
Type: ResolvedRefs