Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Add missing traces for reply traffic to the proxy #27872

Merged
merged 1 commit into from Sep 1, 2023
Merged

bpf: Add missing traces for reply traffic to the proxy #27872

merged 1 commit into from Sep 1, 2023

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Sep 1, 2023 •
edited

This commit adds two missing packet traces for reply traffic to the proxy. Because of those missing traces, we would see a from-container not followed by any to-xxx trace.

Fixes: #22528.

Fix missing packet trace after `from-container` for reply traffic to the proxy.

@pchaigno pchaigno added kind/bug This is a bug in the Cilium logic. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 1, 2023
@pchaigno pchaigno requested a review from a team as a code owner September 1, 2023 08:38
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.2 Sep 1, 2023
@pchaigno pchaigno mentioned this pull request Sep 1, 2023
Open
ldelossa
ldelossa approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldelossa
Copy link
Contributor

ldelossa commented Sep 1, 2023 •
edited

Run coccicheck Expected — Waiting for status to be reported seems to be not running on a few PRs i've passed thru, if it passes locally i'd say merge it...

@pchaigno
bpf: Add missing traces for reply traffic to the proxy
43ba0b6 
This commit adds two missing packet traces for reply traffic to the
proxy. Because of those missing traces, we would see a from-container
not followed by any to-xxx trace.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno
Copy link
Member Author

pchaigno commented Sep 1, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 1, 2023
@christarazi
Copy link
Member

Curious, what changed from #22528 (comment)?

@pchaigno pchaigno merged commit 503417a into cilium:main Sep 1, 2023
60 of 61 checks passed
@pchaigno pchaigno deleted the fix-missing-proxy-traces branch September 1, 2023 22:51
@pchaigno
Copy link
Member Author

pchaigno commented Sep 1, 2023

Curious, what changed from #22528 (comment)?

No idea. I just ran the full connectivity test suite to confirm we see the trace on IPv4.

@jibi jibi mentioned this pull request Sep 4, 2023
Merged
16 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 4, 2023
@michi-covalent michi-covalent moved this from Needs backport from main to Backport done to v1.14 in 1.14.2 Sep 9, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.14.2
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing TRACE_TO_PROXY notification for return traffic to ingress proxy
4 participants
@pchaigno @ldelossa @christarazi @jibi