hubble: Use protobuf GetType() helper in v1.FlowProtocol() to avoid possible panic #27889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancez
added
kind/cleanup
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
michi-covalent
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rolinh
approved these changes
Sep 1, 2023
|
I guess this affects v1.14 and should be backported, correct? |
|
@rolinh Sort of. It's not an actual bug in practice, just a possible bug, so I don't know if we need to backport it. I only noticed when I was writing some new tests in another PR, and the tests were triggering a panic here because the code used this function. |
rolinh
added
the
needs-backport/1.14
lambdanis
approved these changes
Sep 1, 2023
…anic If the event type is unset, or the flow is nil, it's possible that FlowProtocol could panic. To avoid this, use the GetType() helper method which is nil safe. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/hubble_fix_possible_panic_in_metrics
branch
from
cf3299f
to
06d94b9
Compare
|
Rebased, and then I shortened the commit message summary to satisfy |
|
/test |
michi-covalent
deleted the
pr/chancez/hubble_fix_possible_panic_in_metrics
branch
maintainer-s-little-helper
bot
added
ready-to-merge
gandro
added
backport-pending/1.14
gandro
added
backport-done/1.14
jrajahalme
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the event type is unset, or the flow is nil, it's possible that FlowProtocol could panic. To avoid this, use the GetType() helper method which is nil safe.