Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull skb data in cil_from_netdev path for HIGH_SCALE_IPCACHE mode #27913

Merged
merged 1 commit into from Sep 5, 2023

Conversation

sofat1989
Copy link
Contributor

@sofat1989 sofat1989 commented Sep 4, 2023

Now we enabled the high scale ipcache mode. And on some nodes with Mellanox nic cards, we found that cilium dropped the icmp packets for path MTU discovery. So the packets will be dropped when the clients send huge packets.

/# lspci | grep -i Mellanox
1f:00.0 Ethernet controller: Mellanox Technologies MT27520 Family [ConnectX-3 Pro]

xx drop (Invalid packet) flow 0xb18ed4da to endpoint 0, ifindex 4, file 1:1061, , identity unknown->unknown: 10.* -> 10.2* DestinationUnreachable(FragmentationNeeded)
fix bug: pull skb data in cil_from_netdev path for HIGH_SCALE_IPCACHE mode

@sofat1989 sofat1989 requested a review from a team as a code owner September 4, 2023 08:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 4, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 4, 2023
@julianwiedmann julianwiedmann added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. feature/high-scale-ipcache Relates to the high-scale ipcache feature. labels Sep 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 5, 2023
@julianwiedmann
Copy link
Member

/test

@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.2 Sep 5, 2023
@julianwiedmann
Copy link
Member

(I dropped the Fixes: reference to #12854 from the description, as this bug is unrelated to that old issue)

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 5, 2023
@julianwiedmann julianwiedmann merged commit 7664f96 into cilium:main Sep 5, 2023
62 checks passed
@michi-covalent michi-covalent added this to Needs backport from main in 1.14.3 Sep 9, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.14.2 Sep 9, 2023
@gandro gandro mentioned this pull request Sep 12, 2023
15 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 12, 2023
@gandro gandro added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 25, 2023
@jrajahalme jrajahalme moved this from Needs backport from main to Backport done to v1.14 in 1.14.3 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. feature/high-scale-ipcache Relates to the high-scale ipcache feature. kind/bug This is a bug in the Cilium logic. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.14.3
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

None yet

4 participants