envoy: fix lb backend endpoint calculation #27923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
kind/bug
|
/test |
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
mhofstetter
removed
the
stale
|
Looks good, sorry for the delay, was there an issue for this bug? |
tommyp1ckles
approved these changes
Oct 24, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-endpoints-lbendpoints
branch
from
eee6047
to
0ba766b
Compare
mhofstetter
removed
the
ready-to-merge
This commit extracts the logic that creates Envoy endpoints (ClusterLoadAssignments) for LoadBalancing Backends into its function. In addition some unit tests were added. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Currently, mapping loadbalancing backends to Envoy endpoints contains a bug that the LbEndpoints are kept/appended over the whole backendMap. Therefore, later endpoints will contain the LBEndpoints of all previous backends. This commit fixes this by putting the variable `lbEndpoints` into the right scope (per port). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/envoy-endpoints-lbendpoints
branch
from
0ba766b
to
044da91
Compare
|
rebased to |
no problem. no there isn't a reported issue. |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
@mhofstetter This probably needs backports right? (looks like the same issue might exist back to at least v1.13). |
mhofstetter
added
needs-backport/1.13
pippolo84
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.4
pippolo84
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.9
pippolo84
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.9
jibi
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mapping loadbalancing backends to Envoy endpoints contains a bug that the LbEndpoints are kept/appended over the
whole backendMap. Therefore, later endpoints will contain the LBEndpoints of all previous backends.
This commit fixes this by putting the variable
lbEndpointsinto the right scope (per port).