Helm: Improved description for tunnel, tunnelProtocol, routingMode flags #27926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
gandro
approved these changes
Sep 4, 2023
PhilipSchmid
force-pushed
the
pr/philip/helm_description_for_tunnelProtocol_routingMode
branch
from
c35453d
to
fd3dd22
Compare
|
Ugh, I forgot about this, thanks @gandro! I just run this command and git amend'ed the generated file. |
gandro
added
release-note/misc
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
nathanjsweet
approved these changes
Sep 13, 2023
Restarting both |
|
/test |
PhilipSchmid
force-pushed
the
pr/philip/helm_description_for_tunnelProtocol_routingMode
branch
from
fd3dd22
to
3ee196c
Compare
- Improved description for tunnel, tunnelProtocol, routingMode flags to make it clearer for users to know the possible values. - Added deprecation note for the tunnel flag to be in line with the v1.14.0 release notes and cilium#24561. Signed-off-by: Philip Schmid <philip.schmid@isovalent.com>
PhilipSchmid
force-pushed
the
pr/philip/helm_description_for_tunnelProtocol_routingMode
branch
from
3ee196c
to
53d4125
Compare
|
Rebased & fixed two word spellings. @gandro, @nathanjsweet do you think we could merge this PR anytime soon? Let's please backport this to 1.14. For 1.15, |
|
The main reason why this was not yet merged is that there is an outstanding review request for docs by @qmonnet - Quentin, mind taking a look? Otherwise I think we can merge without docs approval, since the changes mainly affect the Helm README. Let's also run CI and then this should be mergable. |
|
/test |
gandro
added
the
needs-backport/1.14
|
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.3
aanm
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--tunnelflag to allow setting a tunneling protocol for a subset of traffic #24561.Please ensure your pull request adheres to the following guidelines:
Internal Slack discussion: https://isovalent.slack.com/archives/C01742ANV9P/p1693834569477619