New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Makefile and documentation for "fast" development targets #27931
Conversation
5ccf15d
to
6a357ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good. Some suggestions only, feel free to discard.
Thanks for this!
Is it something we could backport, so we could use it when troubleshooting issues on the older branches, as well? |
This commit introduces documentation for "fast" development targets in Cilium. The "fast" targets allow for quicker development workflows by building Cilium locally and deploying it on an existing kind cluster. This approach eliminates the need to create and deploy Docker images each time a source code change is made. Additionally, the documentation has been updated to include these new Makefile targets and provides a quick start guide with essential information for working with Cilium. When a cluster is already running with a Cilium container, we can simply volume mount the binaries into the container and restart the pod to pick up the changes. A similar approach can be used for C code, with the caveat that the bpf/lib directory needs write permissions by Cilium to generate the C Header features file, making it impossible to use the volume as read-only. Since all nodes share the same kernel features, there won't be any conflicts when multiple nodes write to the same volume mount. Signed-off-by: André Martins <andre@cilium.io>
6a357ee
to
873ba97
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Very cool! Do you think that at some point we could combine the |
This is to print out command hints for Linux host, so that new Cilium contributors didn't need to check docs. Relates: cilium#27931 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to print out command hints for Linux host, so that new Cilium contributors didn't need to check docs. Relates: #27931 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to print out command hints for Linux host, so that new Cilium contributors didn't need to check docs. Relates: cilium#27931 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This commit introduces documentation for "fast" development targets in Cilium. The "fast" targets allow for quicker development workflows by building Cilium locally and deploying it on an existing kind cluster. This approach eliminates the need to create and deploy Docker images each time a source code change is made.
Additionally, the documentation has been updated to include these new Makefile targets and provides a quick start guide with essential information for working with Cilium.
When a cluster is already running with a Cilium container, we can simply volume mount the binaries into the container and restart the pod to pick up the changes. A similar approach can be used for C code, with the caveat that the bpf/lib directory needs write permissions by Cilium to generate the C Header features file, making it impossible to use the volume as read-only. Since all nodes share the same kernel features, there won't be any conflicts when multiple nodes write to the same volume mount.