Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endpoint: Fix use of PolicyMapFullReconciliationInterval option #27985

Merged
merged 1 commit into from Sep 12, 2023
Merged

endpoint: Fix use of PolicyMapFullReconciliationInterval option #27985

merged 1 commit into from Sep 12, 2023

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Sep 7, 2023

The last minute change in 867e41a to add an option for configuring the full endpoint policy sync forgot to actually change the use-site.

Fixes: 867e41a ("endpoint: Only perform full synchronization periodically")

@joamaki
endpoint: Fix use of PolicyMapFullReconciliationInterval option
31c26c2 
The last minute change in 867e41a to add an option for configuring the
full endpoint policy sync forgot to actually change the use-site.

Fixes: 867e41a ("endpoint: Only perform full synchronization periodically")
Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki requested a review from a team as a code owner September 7, 2023 07:35
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 7, 2023
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label Sep 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 7, 2023
@joamaki
Copy link
Contributor Author

joamaki commented Sep 7, 2023

Marking as release-note/misc since this fixes an issue in just merged PR that never made it into a release.

@joamaki
Copy link
Contributor Author

joamaki commented Sep 7, 2023

I validated that this option now correctly works by setting it to 1m and running cilium status --verbose and validated that the controller indeed ran once per minute.

@aanm
Copy link
Member

aanm commented Sep 11, 2023

/test

@joamaki joamaki added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 11, 2023
@joamaki joamaki merged commit a883ef3 into cilium:main Sep 12, 2023
61 of 62 checks passed
@joamaki joamaki mentioned this pull request Sep 12, 2023
Merged
15 tasks
@gandro
Copy link
Member

gandro commented Sep 12, 2023

Adding backport/author for v1.12 and v1.13 (I'll take care of v1.14)

@gandro gandro added backport/author The backport will be carried out by the author of the PR. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 12, 2023
@joamaki joamaki mentioned this pull request Sep 15, 2023
Merged
6 tasks
@gandro gandro added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 25, 2023
@joamaki joamaki added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed needs-backport/1.12 labels Sep 26, 2023
@joamaki joamaki mentioned this pull request Oct 5, 2023
Merged
5 tasks
@jrajahalme jrajahalme mentioned this pull request Oct 18, 2023
Merged
@julianwiedmann julianwiedmann added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles is a code owner automatically assigned from cilium/endpoint

Assignees
No one assigned
Labels
backport/author The backport will be carried out by the author of the PR. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joamaki @aanm @gandro @julianwiedmann