Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gateway API HttpRoute cannot strip path prefix. #28018

Merged
merged 1 commit into from Sep 14, 2023
Merged

Fix Gateway API HttpRoute cannot strip path prefix. #28018

merged 1 commit into from Sep 14, 2023

Conversation

chaunceyjiang
Copy link
Member

According to Kubernetes guidlines empty prefix should be allowed.

Fixes: #27994

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

Fix Gateway API HttpRoute cannot strip path prefix.

@chaunceyjiang chaunceyjiang requested a review from a team as a code owner September 8, 2023 08:46
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 8, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 8, 2023
@chaunceyjiang
Fix Gateway API HttpRoute cannot strip path prefix.
70a19f4 
According to Kubernetes guidlines empty prefix should be allowed.

Fixes: cilium#27994

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Member Author

Hi, @meyskens Ready for review. Please take a look. Thanks~

@meyskens meyskens added kind/bug This is a bug in the Cilium logic. area/servicemesh GH issues or PRs regarding servicemesh feature/k8s-gateway-api release-note/bug This PR fixes an issue in a previous release of Cilium. and removed kind/bug This is a bug in the Cilium logic. labels Sep 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 14, 2023
meyskens
meyskens approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@meyskens meyskens added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Sep 14, 2023
@meyskens
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 14, 2023
@julianwiedmann julianwiedmann merged commit 567bc43 into cilium:main Sep 14, 2023
60 of 61 checks passed
@giorio94 giorio94 mentioned this pull request Sep 26, 2023
Merged
22 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 26, 2023
@aanm aanm added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 29, 2023
@jrajahalme jrajahalme mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyskens meyskens meyskens approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. feature/k8s-gateway-api kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway API HttpRoute cannot strip path prefix
5 participants
@chaunceyjiang @meyskens @aanm @julianwiedmann @giorio94