CI Images: Don't push floating tags from feature branches #28044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
i guess it does what we want, but it doesn't feel very elegant. requesting review from @nbusseneau to see if he has any suggestions 🚀 🙏 ✨ |
|
/test |
nbusseneau
approved these changes
Sep 11, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
nbusseneau
requested changes
Sep 11, 2023
maintainer-s-little-helper
bot
removed
the
ready-to-merge
Floating tags like "latest" or "v1.14" should only be pushed from main or stable branches. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/feature
branch
from
57806f9
to
9fab583
Compare
|
/test |
nbusseneau
approved these changes
Sep 19, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
added a commit
to michi-covalent/cilium
that referenced
this pull request
Sep 19, 2023
Define a variable for CI image floating tags instead of hardcoding it. - For the main branch, the floating tag is "latest". - For stable branches, the floating tag is the same as the branch name (e.g. "v1.14"). This commit was initially introduced in cilium#28008, but it got reverted because it tried to push floating tags for feature branches and failed. Now that cilium#28044 is merged, this workflow no longer pushes floating tags from feature branches. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to michi-covalent/cilium
that referenced
this pull request
Sep 19, 2023
Define a variable for CI image floating tags instead of hardcoding it. - For the main branch, the floating tag is "latest". - For stable branches, the floating tag is the same as the branch name (e.g. "v1.14"). This commit was initially introduced in cilium#28008, but it got reverted because it tried to push floating tags for feature branches and failed. Now that cilium#28044 is merged, this workflow no longer pushes floating tags from feature branches. Therefore it is safe to use github.ref_name as a floating tag. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Sep 21, 2023
Define a variable for CI image floating tags instead of hardcoding it. - For the main branch, the floating tag is "latest". - For stable branches, the floating tag is the same as the branch name (e.g. "v1.14"). This commit was initially introduced in #28008, but it got reverted because it tried to push floating tags for feature branches and failed. Now that #28044 is merged, this workflow no longer pushes floating tags from feature branches. Therefore it is safe to use github.ref_name as a floating tag. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
gandro
pushed a commit
to gandro/cilium
that referenced
this pull request
Oct 10, 2023
[ upstream commit 5b55b65 ] Define a variable for CI image floating tags instead of hardcoding it. - For the main branch, the floating tag is "latest". - For stable branches, the floating tag is the same as the branch name (e.g. "v1.14"). This commit was initially introduced in cilium#28008, but it got reverted because it tried to push floating tags for feature branches and failed. Now that cilium#28044 is merged, this workflow no longer pushes floating tags from feature branches. Therefore it is safe to use github.ref_name as a floating tag. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
pchaigno
pushed a commit
that referenced
this pull request
Jan 8, 2024
[ upstream commit 5b55b65 ] Define a variable for CI image floating tags instead of hardcoding it. - For the main branch, the floating tag is "latest". - For stable branches, the floating tag is the same as the branch name (e.g. "v1.14"). This commit was initially introduced in #28008, but it got reverted because it tried to push floating tags for feature branches and failed. Now that #28044 is merged, this workflow no longer pushes floating tags from feature branches. Therefore it is safe to use github.ref_name as a floating tag. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating tags like "latest" or "v1.14" should only be pushed from main and stable branches.