ci: Run BPF lints on workflow definition changes #28122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
area/CI-improvement
|
/test |
|
Hmm the file change was correctly detected, but the jobs were skipped anyway 🤔 |
In the past, we have merged automated updates to the coccicheck image version (for example, [0]) without realising they may break the workflow, because the workflow wouldn't run on the PR, which contained no BPF-related changes. Let's make the workflow run when its definition file is updated, to make sure we can catch similar issues in the future. [0] cilium#27947 Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/bpf-checks-on-workflow-def
branch
from
338fe00
to
96ee1c4
Compare
|
/test |
aanm
approved these changes
Sep 12, 2023
nebril
approved these changes
Sep 13, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
doniacld
added
backport-pending/1.13
This was referenced Sep 26, 2023
giorio94
added
backport-pending/1.14
aanm
added
backport-done/1.14
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we have merged automated updates to the coccicheck image version (for example) without realising they may break the workflow, because the workflow wouldn't run on the PR, which contained no BPF-related changes.
Let's make the workflow run when its definition file is updated, to make sure we can catch similar issues in the future.