[v1.14] Fix minor bug where the previous Cilium proxy port was not reused #28127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit b0e63b7 ] In the upcoming commits, the DNS proxy code and the datapath iptables code need to share a few variables. This commit is necessary to prevent an import cycle. Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit f1913e3 ] This will be useful for the upcoming commit to use in the datapath / iptables packages for extracting shared state from iptables rules related to the DNS proxy. Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 1f8e015 ] In a previous change [1], the bind address for the proxy changed from 0.0.0.0 to localhost. This broke restoring the old proxy port and caused Cilium to always allocate a new proxy port. Fix it by changing the regex string to include the new bind address as well as the previously used "0.0.0.0" and "::", for backwards-compatibility reasons on upgrade. Found by code inspection. [1]: #25309 Fixes: 5304088 ("dnsproxy: bind dns proxy to localhost only") Fixes: #25309 Signed-off-by: Chris Tarazi <chris@isovalent.com>
maintainer-s-little-helper
bot
added
backport/1.14
christarazi
changed the title
|
/test-backport-1.14 |
mhofstetter
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via:
or with