Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update IPsec key rotation command #28141

Merged
merged 1 commit into from Oct 16, 2023
Merged

docs: Update IPsec key rotation command #28141

merged 1 commit into from Oct 16, 2023

Conversation

jschwinger233
Copy link
Member

The previous command relies on awk(1) which could behave differently on Linux and macOS. This patch uses kubectl -o go-template to remove dependency on awk(1), makes sure key rotation operation works properly on both platform.

Signed-off-by: Zhichuan Liang gray.liang@isovalent.com

@jschwinger233
docs: Update IPsec key rotation command
cc2e3e8 
The previous command relies on awk(1) which could behave differently on
Linux and macOS. This patch uses `kubectl -o go-template` to remove
dependency on awk(1), makes sure key rotation operation works properly
on both platform.

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 13, 2023
@jschwinger233 jschwinger233 added the release-note/misc This PR makes changes that have no direct user impact. label Sep 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 13, 2023
@jschwinger233 jschwinger233 added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Sep 13, 2023
@jschwinger233 jschwinger233 marked this pull request as ready for review September 13, 2023 11:54
@jschwinger233 jschwinger233 requested review from a team as code owners September 13, 2023 11:54
brb
brb approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Another option is to use more canonical(?) -o jsonpath=.

zacharysarah
zacharysarah approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@margamanterola margamanterola added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 14, 2023
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Oct 15, 2023
@pchaigno pchaigno added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Oct 15, 2023
@squeed squeed merged commit 42ef7f3 into cilium:main Oct 16, 2023
42 checks passed
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 24, 2023
This was referenced Oct 24, 2023
Merged
Merged
@tklauser tklauser added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Oct 24, 2023
@tklauser tklauser mentioned this pull request Oct 24, 2023
Merged
6 tasks
@tklauser tklauser added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Oct 25, 2023
@julianwiedmann julianwiedmann added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Oct 26, 2023
@thorn3r thorn3r mentioned this pull request Nov 9, 2023
Merged
This was referenced Nov 12, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margamanterola margamanterola margamanterola left review comments

@brb brb brb approved these changes

@pchaigno pchaigno pchaigno approved these changes

@zacharysarah zacharysarah zacharysarah approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jschwinger233 @brb @pchaigno @zacharysarah @margamanterola @tklauser @squeed @julianwiedmann