Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't orphan CEPs when node IPV6 is preferred at dual stack k8s config #28142

Merged
merged 1 commit into from Oct 30, 2023
Merged

Don't orphan CEPs when node IPV6 is preferred at dual stack k8s config #28142

merged 1 commit into from Oct 30, 2023

Conversation

rawmind0
Copy link
Contributor

This commit prevents a soft deadlock in the cilium agent on dual stack k8s config with ipv6 preferred by making it check to both ip families CEP's node IPs.

Fixes: #28139

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #28139

@rawmind0 rawmind0 requested a review from a team as a code owner September 13, 2023 12:14
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 13, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 13, 2023
@aanm aanm added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels Sep 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 15, 2023
@aanm aanm added sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 15, 2023
@aanm aanm removed the request for review from joamaki September 15, 2023 23:34
@aanm
Copy link
Member

aanm commented Sep 15, 2023

/test

@rawmind0
Copy link
Contributor Author

Branch rebased

@rawmind0
Copy link
Contributor Author

Branch rebased

@aanm
Copy link
Member

aanm commented Sep 26, 2023

/test

@maintainer-s-little-helper
Copy link

Commit 40b7cd292bf0c141ed5b6bf79b7ec8c3fd9733be does not match "(?m)^Signed-off-by:".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 27, 2023
@rawmind0
Copy link
Contributor Author

Branch rebased

@rawmind0 rawmind0 force-pushed the fix/orphan branch 3 times, most recently from f60adac to 173887d Compare September 29, 2023 14:15
@rawmind0
Copy link
Contributor Author

Branch rebased

@ti-mo
Copy link
Contributor

ti-mo commented Oct 4, 2023

/test

@squeed
Copy link
Contributor

squeed commented Oct 10, 2023

poke @tommyp1ckles for review :-)

@squeed squeed requested review from squeed and removed request for tommyp1ckles October 11, 2023 15:19
@rawmind0 rawmind0 force-pushed the fix/orphan branch 2 times, most recently from af3eade to 783cf84 Compare October 23, 2023 12:31
@squeed
Copy link
Contributor

squeed commented Oct 25, 2023

/test

@rawmind0
Copy link
Contributor Author

Branch rebased

@rawmind0
Don't orphan CEPs when node IPV6 is preferred at dual stack k8s config
6c5e5a8 
This commit prevents a soft deadlock in the cilium agent on dual stack k8s config with ipv6 preferred by making it check to both ip families CEP's node IPs.

Fixes: cilium#28139

Signed-off-by: Raul S. <rawmind@gmail.com>
@rawmind0
Copy link
Contributor Author

Branch rebased

@tommyp1ckles
Copy link
Contributor

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 30, 2023
@aanm aanm merged commit 130ab8d into cilium:main Oct 30, 2023
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cilium can fail to take over ownership of CEP in k8s dual stack cluster with preferred ipv6
5 participants
@rawmind0 @aanm @ti-mo @squeed @tommyp1ckles