docs: Add more details for the Cluster Mesh key rotation #28145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margamanterola
added
area/documentation
margamanterola
force-pushed
the
pr/marga/update-ipsec-rotation-docs
branch
from
8f8aaea
to
d19d3d3
Compare
jschwinger233
approved these changes
Sep 13, 2023
zacharysarah
requested changes
Sep 13, 2023
There was a problem hiding this comment.
@margamanterola Valuable PR! ✨ Some small edits for clarity, otherwise LGTM
margamanterola
force-pushed
the
pr/marga/update-ipsec-rotation-docs
branch
from
d19d3d3
to
f7a9dc4
Compare
Rather than having this information hidden in a parenthesis in the troubleshooting section, let's have a full paragraph in the key rotation section that explains what needs to be done when using Cluster Mesh. Signed-off-by: Marga Manterola <marga@isovalent.com>
margamanterola
force-pushed
the
pr/marga/update-ipsec-rotation-docs
branch
from
f7a9dc4
to
b099856
Compare
margamanterola
added
needs-backport/1.12
needs-backport/1.13
|
This is a documentation-only check, so no need to waste energy running conformance tests. Setting ready-to-merge. |
margamanterola
added
the
ready-to-merge
doniacld
added
backport-pending/1.13
giorio94
added
backport-pending/1.14
aanm
added
backport-done/1.14
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having this information hidden in a parenthesis in the troubleshooting section, let's have a full paragraph in the key rotation section that explains what needs to be done when using Cluster Mesh.