build: fix usage of local golangci-lint installation

[mhofstetter]

The make target make lint should prefer the locally installed golangci-lint if the installed version matches the expected one. This comes with the advantage of using the local cache.

It seems that there are differences in the version representation between the upstream binaries (including the v prefix) and the one installed via go install ... (without the prefix). The current implementation doesn't support the upstream binaries with the v prefix - it always falls back to executing the docker version.

This commit introduces support for both formats by stripping any given v prefix before comparison.

[mhofstetter]

/test

[tklauser]

(e.g. golangci-lint has version 1.54.2 built with go1.21.0 from 411e0bbb on 2023-08-21T12:04:32Z (that doesn't contain the version with a prefix v)

Interestingly, my locally installed golangci-lint does have the v prefix:

golangci-lint has version v1.54.2 built with go1.21.1 from (unknown, mod sum: "h1:oR9zxfWYxt7hFqk6+fw6Enr+E7F0SN2nqHhJYyIb0yo=") on (unknown)

I guess this is because I installed it using go install. The binaries provided by upstream don't have the v prefix. Presumably this is why we use findstring instead of an exact match.

[mhofstetter]

(e.g. golangci-lint has version 1.54.2 built with go1.21.0 from 411e0bbb on 2023-08-21T12:04:32Z (that doesn't contain the version with a prefix v)

Interestingly, my locally installed golangci-lint does have the v prefix:

golangci-lint has version v1.54.2 built with go1.21.1 from (unknown, mod sum: "h1:oR9zxfWYxt7hFqk6+fw6Enr+E7F0SN2nqHhJYyIb0yo=") on (unknown)

I guess this is because I installed it using go install. The binaries provided by upstream don't have the v prefix. Presumably this is why we use findstring instead of an exact match.

Interesting find. I wondered why this is "suddenly" no longer working. I was pretty sure that this worked even after introducing automated Renovate upgrades. Currently i have it installed via their recommended "binaries" approach.

What's the output of golangci-lint version --format short in your version? If this is more reliable - we should switch to this instead of the full version.

[tklauser]

What's the output of golangci-lint version --format short in your version? If this is more reliable - we should switch to this instead of the full version.

% golangci-lint version --format short
v1.54.2

But I guess we cannot rely on that format. Presumably developers will also use the prebuilt binaries so we should probably assume both version formats for the purpose of the lint target.

[mhofstetter]

What's the output of golangci-lint version --format short in your version? If this is more reliable - we should switch to this instead of the full version.

Oh it seems that they also differ in the short version :( Guess i have to remove the prefix anyway

[mhofstetter]

/test