Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: Remove priviledged helm option in {Ingress, Gateway} #28200

Merged
merged 1 commit into from Sep 18, 2023

Conversation

sayboras
Copy link
Member

Originally, this option is added for old minikube version, which requires priviledge permission to mount ebpf dir, however, we have migrated to kind + metallb in Ingress and Gateway related workflows.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 18, 2023
@sayboras sayboras added release-note/ci This PR makes changes to the CI. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Sep 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.8 Sep 18, 2023
@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review September 18, 2023 09:05
@sayboras sayboras requested review from a team as code owners September 18, 2023 09:05
Originally, this option is added for old minikube version, which
requires privilege permission to mount ebpf dir, however, we have
migrated to kind + metallb in Ingress and Gateway related workflows.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 18, 2023
@sayboras sayboras merged commit 58366eb into main Sep 18, 2023
200 of 203 checks passed
@sayboras sayboras deleted the tam/remove-privileged-option branch September 18, 2023 10:33
@doniacld doniacld mentioned this pull request Sep 22, 2023
10 tasks
@doniacld doniacld added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Sep 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.8 Sep 22, 2023
@aanm aanm added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Sep 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.8 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.13.8
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

None yet

4 participants