Make tolerations configurable in clustermesh-apiserver certgen job #28221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A certgen job can be used to generate the TLS certificates required both for hubble and clustermesh. Yet, the clustermesh one lacks the possibility of configuring additional tolerations, which are instead configurable in the hubble case. This is possibly useful for instance to allow running the job on control-plane nodes. Hence, let's fix this divergence. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
area/clustermesh
|
/test |
2 tasks
sayboras
approved these changes
Sep 20, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
Should we backport this to v1.14? Considering it seems to be a blocker for some users (ref #28167) |
Makes sense to me, marking for backport to v1.14. |
giorio94
added
the
needs-backport/1.14
giorio94
added
backport-pending/1.14
aanm
added
backport-done/1.14
jrajahalme
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A certgen job can be used to generate the TLS certificates required both for hubble and clustermesh. Yet, the clustermesh one lacks the possibility of configuring additional tolerations, which are instead configurable in the hubble case. This is possibly useful for instance to allow running the job on control-plane nodes. Hence, let's fix this divergence.
Related: #28167