Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove the latest image tag from docs as latest tag is not published #28241

Merged
merged 1 commit into from Oct 4, 2023
Merged

fix: Remove the latest image tag from docs as latest tag is not published #28241

merged 1 commit into from Oct 4, 2023

Conversation

vipul-21
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Remove the latest image tag from the docs as it does not get published. By default it will pick the version from the VERSION file of the github.

Fixes: #27473

@vipul-21
fix: Remove the latest image tag from docs as latest tag is not publi…
7c4cc90 
…shed

Signed-off-by: Vipul Singh <vipul21sept@gmail.com>
@vipul-21 vipul-21 requested a review from a team as a code owner September 21, 2023 05:22
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 21, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 21, 2023
zacharysarah
zacharysarah approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM

@lmb lmb added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Sep 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 28, 2023
@lmb
Copy link
Contributor

lmb commented Sep 28, 2023

/test

@ti-mo ti-mo merged commit d031248 into cilium:main Oct 4, 2023
59 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement/correction in documentation - https://docs.cilium.io/en/latest/installation/kind/
4 participants
@vipul-21 @lmb @zacharysarah @ti-mo