Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Updates L2 Announce for LB Class Support #28252

Merged
merged 1 commit into from Oct 10, 2023
Merged

Docs: Updates L2 Announce for LB Class Support #28252

merged 1 commit into from Oct 10, 2023

Conversation

danehans
Copy link
Contributor

Updates L2 announcer docs for load balancer class support.

Fixes: #28236

@danehans danehans requested a review from a team as a code owner September 22, 2023 15:43
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 22, 2023
@danehans
Copy link
Contributor Author

cc @dylandreimerink

@danehans
Copy link
Contributor Author

@learnitall when you have a moment, PTAL.

learnitall
learnitall requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit on formatting, but otherwise LGTM.

Documentation/network/l2-announcements.rst Outdated Show resolved Hide resolved
@learnitall learnitall added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Sep 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 28, 2023
@danehans
Docs: Updates L2 Announce for LB Class Support
cd13b8a 
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
@danehans
Copy link
Contributor Author

danehans commented Oct 6, 2023

@dylandreimerink @learnitall do you have any suggetions for getting this PR merged?

@learnitall learnitall added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 9, 2023
@learnitall
Copy link
Contributor

Hey @danehans I'll mark this ready-to-merge so it'll get picked up.

Docs-only change, full test suite is not required and all other tests are green. Marking ready to merge.

@squeed squeed merged commit 2554edd into cilium:main Oct 10, 2023
41 checks passed
@danehans danehans deleted the issue_28236 branch March 8, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add LoadBalancerClass to L2 Announcements
4 participants
@danehans @learnitall @dylandreimerink @squeed