Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add instructions for running LVH against custom kernel #28305

Merged
merged 1 commit into from Sep 28, 2023
Merged

docs: Add instructions for running LVH against custom kernel #28305

merged 1 commit into from Sep 28, 2023

Conversation

brb
Copy link
Member

@brb brb commented Sep 27, 2023

No description provided.

@brb brb added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.3 Sep 27, 2023
@brb brb force-pushed the pr/brb/docs-lvh-custom-kernel branch 4 times, most recently from d5313f9 to 23233c7 Compare September 27, 2023 14:06
@brb brb marked this pull request as ready for review September 27, 2023 14:08
@brb brb requested review from a team as code owners September 27, 2023 14:08
lambdanis
lambdanis requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A localization nit, otherwise looks good.

Documentation/contributing/testing/e2e.rst Outdated Show resolved Hide resolved
@brb brb force-pushed the pr/brb/docs-lvh-custom-kernel branch from 23233c7 to b7b1805 Compare September 28, 2023 07:15
@brb brb requested a review from lambdanis September 28, 2023 07:15
bimmlerd
bimmlerd requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of spelling/grammar fixes

Documentation/contributing/testing/e2e.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/e2e.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/e2e.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/e2e.rst Outdated Show resolved Hide resolved
Documentation/contributing/testing/e2e.rst Outdated Show resolved Hide resolved
@brb
docs: Add instructions for running LVH against custom kernel
67b0369 
Also, remove setting custom nameserver
(cilium/little-vm-helper-images#186).

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/docs-lvh-custom-kernel branch from b7b1805 to 67b0369 Compare September 28, 2023 12:08
@brb brb requested a review from bimmlerd September 28, 2023 12:08
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 28, 2023
@lmb lmb merged commit 682038d into main Sep 28, 2023
41 checks passed
@lmb lmb deleted the pr/brb/docs-lvh-custom-kernel branch September 28, 2023 14:18
@sayboras sayboras mentioned this pull request Oct 2, 2023
Merged
3 tasks
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.3 Oct 2, 2023
@aanm aanm removed the backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. label Oct 3, 2023
@aanm aanm added the backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. label Oct 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.3 Oct 3, 2023
@jrajahalme jrajahalme mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdanis lambdanis lambdanis approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.3
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brb @lambdanis @bimmlerd @lmb @aanm @sayboras