Fix data race during Hubble setup #28322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a data race where the setup of the hubbleObserver is being initialized in a new goroutine while the StatusCollector already tries to check Hubble's status. We fix the data race by switching to an atomic pointer to access the `hubbleObserver` in the Daemon struct. Fixing the data race by simply waiting to start the status collector until hubble is initialized does not work, as `launchHubble` could take up to 30s to return while waiting for a TLS certificate and we don't want to block agent startup for this. Fixes: cilium#28291 Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
glrf
changed the title
giorio94
approved these changes
Sep 28, 2023
giorio94
added
kind/cleanup
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
kaworu
approved these changes
Oct 2, 2023
gandro
approved these changes
Oct 2, 2023
rolinh
approved these changes
Oct 3, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
This commit fixes a data race where the hubbleObserver is being initialized in a new goroutine while the StatusCollector already tries to check Hubble's status.
We fix the data race by switching to an atomic pointer to access the
hubbleObserverin the Daemon struct.Fixing the data race by simply waiting to start the status collector until hubble is initialized does not work, as
launchHubblecould take up to 30s to return while waiting for a TLS certificate and we don't want to block agent startup for this.Fixes: #28291