v1.13 backports 2023-10-02 #28350
Merged
v1.13 backports 2023-10-02 #28350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 4f1f08e ] The plague of copy/pasting strikes again... Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ upstream commit c6fbeb1 ] This target should completely ignore the existing contents of `cilium/values.yaml` since we always generate from the template files. Co-authored-by: Donia Chaiehloudj <donia.cld@isovalent.com> Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ upstream commit cc56e70 ] These resources are enabled in cilum-proxy build, and can be used in CiliumEnvoyConfig directly, however, without related imported statements, Cilium agent will fail to marshal/unmarshal objects. Sample error ``` level=warning msg="Ignoring invalid CiliumEnvoyConfig JSON (proto:\u00a0(line 1:405): unable to resolve \"type.googleapis.com/envoy.extensions.filters.http.router.v3.Router\": \"not found\") ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added
kind/backports
|
/test-backport-1.13 |
nbusseneau
approved these changes
Oct 2, 2023
|
All required CI jobs are passed, reviews are in. Marking this ready to merge. |
sayboras
added
the
ready-to-merge
|
Reviews are in, CI is also checked, marking this ready to merge. |
maintainer-s-little-helper
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cilium/values.yamltarget to.PHONY#28225 -- install/kubernetes: add thecilium/values.yamltarget to.PHONY(@nbusseneau)Once this PR is merged, you can update the PR labels via: