Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve initial waiting for node information with informers #28354

Merged
merged 1 commit into from Oct 16, 2023

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Oct 2, 2023

Before, we were doing periodic calls to k8s control plane with exponential backoff. Now, we use informers to get updates about Node/CiliumNode, which allows us to react much faster after cilium-operator assigns CIDR to node.

Fixes: #26833

Improve cilium-agent bootstrap time when using cluster-pool ipam. 

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2023
@marseel marseel force-pushed the fix_waiting_for_node_information branch 2 times, most recently from 1f54124 to 827aede Compare October 2, 2023 15:37
@marseel marseel changed the title Improve initial waiting for node information with inforemers. Improve initial waiting for node information with informers Oct 3, 2023
@marseel marseel force-pushed the fix_waiting_for_node_information branch 2 times, most recently from 59612e8 to 8f7fca5 Compare October 3, 2023 11:02
@marseel marseel added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Oct 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 3, 2023
@marseel marseel force-pushed the fix_waiting_for_node_information branch from 8f7fca5 to eacf1b9 Compare October 4, 2023 10:43
@marseel
Copy link
Contributor Author

marseel commented Oct 4, 2023

/test

@marseel marseel force-pushed the fix_waiting_for_node_information branch from eacf1b9 to 8e406a3 Compare October 4, 2023 15:19
@marseel
Copy link
Contributor Author

marseel commented Oct 4, 2023

/test

@marseel marseel force-pushed the fix_waiting_for_node_information branch from 8e406a3 to 8ae3b23 Compare October 5, 2023 10:15
@marseel
Copy link
Contributor Author

marseel commented Oct 5, 2023

/test

@marseel marseel marked this pull request as ready for review October 5, 2023 14:38
@marseel marseel requested review from a team as code owners October 5, 2023 14:38
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marseel Tx Marcel. Nice work! Just a couple comments...

daemon/k8s/resources.go Show resolved Hide resolved
daemon/k8s/init.go Outdated Show resolved Hide resolved
@marseel marseel force-pushed the fix_waiting_for_node_information branch from 8ae3b23 to deecda2 Compare October 9, 2023 09:16
@marseel
Copy link
Contributor Author

marseel commented Oct 9, 2023

/test

@marseel marseel force-pushed the fix_waiting_for_node_information branch from deecda2 to 4399588 Compare October 12, 2023 10:15
@marseel
Copy link
Contributor Author

marseel commented Oct 12, 2023

/test

Before, we were doing periodic calls to k8s control plane with
exponential backoff. Now, we use informers to get updates about
Node/CiliumNode, which allows us to react much faster after
cilium-operator assigns CIDR to node.

Fixes: cilium#26833

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the fix_waiting_for_node_information branch from 4399588 to c3aa45b Compare October 13, 2023 10:50
@marseel
Copy link
Contributor Author

marseel commented Oct 13, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 16, 2023
@squeed squeed merged commit 9638c9d into cilium:main Oct 16, 2023
61 of 62 checks passed
@christarazi christarazi added the kind/performance There is a performance impact of this. label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/performance There is a performance impact of this. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use informer for getting node information instead of periodic polling during agent initialization
5 participants