New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve initial waiting for node information with informers #28354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Oct 2, 2023
marseel
force-pushed
the
fix_waiting_for_node_information
branch
2 times, most recently
from
October 2, 2023 15:37
1f54124
to
827aede
Compare
marseel
changed the title
Improve initial waiting for node information with inforemers.
Improve initial waiting for node information with informers
Oct 3, 2023
marseel
force-pushed
the
fix_waiting_for_node_information
branch
2 times, most recently
from
October 3, 2023 11:02
59612e8
to
8f7fca5
Compare
marseel
added
the
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
label
Oct 3, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Oct 3, 2023
marseel
force-pushed
the
fix_waiting_for_node_information
branch
from
October 4, 2023 10:43
8f7fca5
to
eacf1b9
Compare
/test |
marseel
force-pushed
the
fix_waiting_for_node_information
branch
from
October 4, 2023 15:19
eacf1b9
to
8e406a3
Compare
/test |
marseel
force-pushed
the
fix_waiting_for_node_information
branch
from
October 5, 2023 10:15
8e406a3
to
8ae3b23
Compare
/test |
derailed
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marseel Tx Marcel. Nice work! Just a couple comments...
marseel
force-pushed
the
fix_waiting_for_node_information
branch
from
October 9, 2023 09:16
8ae3b23
to
deecda2
Compare
/test |
marseel
force-pushed
the
fix_waiting_for_node_information
branch
from
October 12, 2023 10:15
deecda2
to
4399588
Compare
/test |
Before, we were doing periodic calls to k8s control plane with exponential backoff. Now, we use informers to get updates about Node/CiliumNode, which allows us to react much faster after cilium-operator assigns CIDR to node. Fixes: cilium#26833 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel
force-pushed
the
fix_waiting_for_node_information
branch
from
October 13, 2023 10:50
4399588
to
c3aa45b
Compare
/test |
youngnick
approved these changes
Oct 16, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/performance
There is a performance impact of this.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were doing periodic calls to k8s control plane with exponential backoff. Now, we use informers to get updates about Node/CiliumNode, which allows us to react much faster after cilium-operator assigns CIDR to node.
Fixes: #26833