Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: Add map pressure metric for auth map #28357

Merged
merged 1 commit into from Oct 3, 2023
Merged

metrics: Add map pressure metric for auth map #28357

merged 1 commit into from Oct 3, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Oct 2, 2023 •
edited

Description

This commit is to make sure that we are having map pressure metric for auth map to improve observability, which can be useful for adjusting map size if required.

Relates: #24617

Testing

Testing was done locally with some auth policies, and then check the metrics as per below

$ ksysex ds/cilium -- cilium metrics list | grep pressure
Defaulted container "cilium-agent" out of: cilium-agent, config (init), mount-cgroup (init), apply-sysctl-overwrites (init), wait-for-node-init (init), clean-cilium-state (init), install-cni-binaries (init)
cilium_bpf_map_pressure                               map_name="cilium_auth_map"                                                                                                                                                                                                    0.000004
cilium_bpf_map_pressure                               map_name="ipcache"                                                                                                                                                                                                            0.000021
cilium_bpf_map_pressure                               map_name="lb4_backends_v3"                                                                                                                                                                                                    0.000046
cilium_bpf_map_pressure                               map_name="lb4_reverse_nat"                                                                                                                                                                                                    0.000397
cilium_bpf_map_pressure                               map_name="lb4_services_v2"                                                                                                                                                                                                    0.000397
cilium_bpf_map_pressure                               map_name="lxc"

@sayboras
metrics: Add map pressure metric for auth map
6a0a9f7 
This commit is to make sure that we are having map pressure metric for
auth map to improve observability, which can be useful for adjusting
map size if required.

Relates: cilium#24617

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2023
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2023
@sayboras sayboras added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.3 Oct 2, 2023
@sayboras
Copy link
Member Author

sayboras commented Oct 2, 2023

/test

@sayboras sayboras marked this pull request as ready for review October 2, 2023 14:15
@sayboras sayboras requested review from a team as code owners October 2, 2023 14:15
meyskens
meyskens approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 3, 2023
@sayboras sayboras merged commit b4da4e6 into cilium:main Oct 3, 2023
60 of 62 checks passed
@sayboras sayboras deleted the tam/authmap-metrics branch October 3, 2023 21:43
@sayboras sayboras mentioned this pull request Oct 6, 2023
Merged
9 tasks
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.3 Oct 6, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 9, 2023
@jrajahalme jrajahalme moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.3 Oct 18, 2023
@jrajahalme jrajahalme mentioned this pull request Oct 18, 2023
Merged
@youngnick youngnick mentioned this pull request Jan 16, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentoo-root gentoo-root gentoo-root approved these changes

@meyskens meyskens meyskens approved these changes

Assignees
No one assigned
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.14.3
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sayboras @gentoo-root @meyskens