Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention RouteTableInterfacesOffset in system requirements #28358

Merged
merged 1 commit into from Oct 3, 2023

Conversation

gandro
Copy link
Member

@gandro gandro commented Oct 2, 2023

ENI mode creates routing tables with index 10 + eni-index. This commit documents that and mentions that those indices are not taken by the system.

Suggested-by: Chris Tarazi chris@isovalent.com

@gandro gandro added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 2, 2023
@gandro gandro requested review from a team as code owners October 2, 2023 14:28
@gandro gandro requested review from aspsk and qmonnet October 2, 2023 14:28
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.3 Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.8 Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.15 Oct 2, 2023
@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Oct 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2023
@gandro gandro force-pushed the pr/gandro/docs-eni-routing-table-index branch from 4155f40 to 984a786 Compare October 2, 2023 14:44
ENI mode creates routing tables with index `10 + eni-index`. This commit
documents that and mentions that those indices are not taken by the
system.

Suggested-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro force-pushed the pr/gandro/docs-eni-routing-table-index branch from 984a786 to 30a5931 Compare October 2, 2023 14:58
@gandro
Copy link
Member Author

gandro commented Oct 2, 2023

Thanks for the review @qmonnet - I fixed the mistakes, good catches!

@gandro gandro requested a review from qmonnet October 2, 2023 14:59
@gandro gandro requested review from christarazi and removed request for aspsk October 2, 2023 15:00
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@qmonnet
Copy link
Member

qmonnet commented Oct 2, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 2, 2023
@gandro gandro merged commit 9d3976c into cilium:main Oct 3, 2023
58 checks passed
@sayboras sayboras mentioned this pull request Oct 6, 2023
9 tasks
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.3 Oct 6, 2023
@sayboras sayboras mentioned this pull request Oct 6, 2023
5 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.8 Oct 6, 2023
@sayboras sayboras mentioned this pull request Oct 6, 2023
5 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.15 Oct 6, 2023
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.15 Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.12 in 1.12.15 Oct 6, 2023
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.12 in 1.12.15 Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.8 Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport done to v1.13 in 1.13.8 Oct 6, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 9, 2023
@jrajahalme jrajahalme moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.3 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.12.15
Backport done to v1.12
1.14.3
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

None yet

4 participants