Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Only Add Enabled IPs to Labels #28360

Merged
merged 1 commit into from Oct 25, 2023
Merged

node: Only Add Enabled IPs to Labels #28360

merged 1 commit into from Oct 25, 2023

Conversation

nathanjsweet
Copy link
Member

When observing changes in host IPs, ensure that
only enabled IP families (e.g. IPv4 and IPv6) are
added to the node labels.

@nathanjsweet nathanjsweet added the release-note/misc This PR makes changes that have no direct user impact. label Oct 2, 2023
@nathanjsweet nathanjsweet marked this pull request as ready for review October 2, 2023 16:27
@nathanjsweet nathanjsweet requested a review from a team as a code owner October 2, 2023 16:27
@christarazi christarazi added area/daemon Impacts operation of the Cilium daemon. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies. sig/agent Cilium agent related. labels Oct 3, 2023
@christarazi
Copy link
Member

Is this fixing #27464?

@nathanjsweet
Copy link
Member Author

Is this fixing #27464?

No, it won't fix anything, but it will improve performance.

@nathanjsweet
Copy link
Member Author

/test

@christarazi christarazi added the kind/performance There is a performance impact of this. label Oct 4, 2023
@nathanjsweet nathanjsweet added affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch labels Oct 23, 2023
@ldelossa
Copy link
Contributor

@nathanjsweet some conflicts which need to be fixed up.

ldelossa
ldelossa approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks logical. Needs a merge conflict fix.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 24, 2023
@christarazi christarazi added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Oct 24, 2023
@nathanjsweet
node: Only Add Enabled IPs to Labels
2b2bf61 
When observeing changes in host IPs, ensure that
only enabled IP families (e.g. IPv4 and IPv6) are
added to the node labels.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/add-only-relevant-ips-to-ipcache-labels branch from 76e4e56 to 2b2bf61 Compare October 24, 2023 19:32
@nathanjsweet nathanjsweet removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Oct 24, 2023
@nathanjsweet
Copy link
Member Author

/test

@dylandreimerink dylandreimerink merged commit b130341 into main Oct 25, 2023
212 of 214 checks passed
@dylandreimerink dylandreimerink deleted the pr/nathanjsweet/add-only-relevant-ips-to-ipcache-labels branch October 25, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
affects/v1.13 This issue affects v1.13 branch affects/v1.14 This issue affects v1.14 branch area/daemon Impacts operation of the Cilium daemon. kind/performance There is a performance impact of this. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/agent Cilium agent related. sig/policy Impacts whether traffic is allowed or denied based on user-defined policies.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nathanjsweet @christarazi @ldelossa @dylandreimerink