New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf: lxc: remove stale ENABLE_IDENTITY_MARK ifdefs #28391
Conversation
4de20fc ("bpf: Pass security ID via skb->cb from lxc to host") switched these parts from using set_identity_mark() to set_identity_meta(). Thus we no longer have to respect the opt-in that controls whether the skb mark may be used to store the identity. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
/test |
I'm undecided on whether this is a bug fix vs enhancement. Opinions? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm undecided on whether this is a bug fix vs enhancement. Opinions? :)
Looks more like an enhancement to me.
Given that it most likely didn't work before either? Yeah that's fair, thank you! We can always backport later if needed. |
4de20fc ("bpf: Pass security ID via skb->cb from lxc to host") switched these parts from using set_identity_mark() to set_identity_meta(). Thus we no longer have to respect the opt-in that controls whether the skb mark may be used to store the identity.