Do not hardcode the AWS VPC CNI plugin version in the conformance-aws-cni GHA workflow #28392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
|
/ci-awscni |
Currently, we are installing a fixed version of the AWS VPC CNI plugin
version (i.e., v1.11) regardless of the Kubernetes version. Yet, this
means that in certain cases we upgrade it, while in others we downgrade,
it, introducing unnecessary churn.
Let's instead use the default one that gets installed with the given
k8s version. Specifically, for the k8s versions currently tested:
* k8s: v1.23 - AWS VPC CNI: v1.10.4-eksbuild.1
* k8s: v1.24 - AWS VPC CNI: v1.11.4-eksbuild.1
* k8s: v1.25 - AWS VPC CNI: v1.12.2-eksbuild.1
* k8s: v1.26 - AWS VPC CNI: v1.12.5-eksbuild.2
* k8s: v1.27 - AWS VPC CNI: v1.12.6-eksbuild.2
Retrieved through:
for MINOR in $(seq 23 27)
do
echo -n "k8s: v1.$MINOR - AWS VPC CNI: "
aws eks describe-addon-versions --addon-name vpc-cni \
--kubernetes-version 1.$MINOR --output yaml | \
yq '.addons[].addonVersions[] | select(.compatibilities[].defaultVersion == true) | .addonVersion';
done
Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/conformance-aws-cni-plugin
branch
from
efd202d
to
f31c6f8
Compare
giorio94
added
needs-backport/1.12
needs-backport/1.13
nbusseneau
approved these changes
Oct 4, 2023
|
Marking as ready to merge, as the PR only touches a GHA workflow. |
giorio94
added
the
ready-to-merge
sayboras
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.3
sayboras
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.8
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.12
in 1.12.15
github-actions
bot
added
backport-done/1.12
github-actions
bot
added
the
backport-done/1.13
github-actions
bot
added
backport-done/1.14
This was referenced Oct 17, 2023
jrajahalme
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are installing a fixed version of the AWS VPC CNI plugin
version (i.e., v1.11) regardless of the Kubernetes version. Yet, this
means that in certain cases we upgrade it, while in others we downgrade,
it, introducing unnecessary churn.
Let's instead use the default one that gets installed with the given
k8s version. Specifically, for the k8s versions currently tested:
Retrieved through:
Link to successful run: https://github.com/cilium/cilium/actions/runs/6403302318