Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs theme #28403

Merged
merged 2 commits into from Oct 6, 2023
Merged

Update docs theme #28403

merged 2 commits into from Oct 6, 2023

Conversation

raphink
Copy link
Member

@raphink raphink commented Oct 4, 2023

Signed-off-by: Raphaël Pinson raphael@isovalent.com

@raphink
Update docs theme
e2805cd 
Signed-off-by: Raphaël Pinson <raphael@isovalent.com>
@raphink raphink requested a review from a team as a code owner October 4, 2023 17:24
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 4, 2023
@raphink raphink temporarily deployed to docs-builder October 4, 2023 17:24 — with GitHub Actions Inactive
@qmonnet qmonnet requested review from qmonnet and removed request for zacharysarah October 4, 2023 17:34
@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Oct 4, 2023
@qmonnet
Copy link
Member

qmonnet commented Oct 4, 2023

Netlify says:
image

qmonnet
qmonnet requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot that the branch had to be opened in the Cilium repo to have the automated update with the new docs-builder image in the PR. I'll update manually tomorrow.

@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Oct 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 4, 2023
@qmonnet
ci: update docs-builder
3275f29 
Manual update for docs-builder tag, because the related PR's branch was
not opened in the Cilium repository (but from a fork).

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@raphink raphink requested review from a team as code owners October 5, 2023 08:25
@raphink raphink requested a review from brlbil October 5, 2023 08:25
@qmonnet qmonnet temporarily deployed to docs-builder October 5, 2023 08:26 — with GitHub Actions Inactive
@qmonnet
Copy link
Member

qmonnet commented Oct 5, 2023

/test

@qmonnet qmonnet added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.8 Oct 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.3 Oct 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.15 Oct 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 5, 2023
@qmonnet qmonnet merged commit 262d59e into cilium:main Oct 6, 2023
64 checks passed
@sayboras sayboras mentioned this pull request Oct 6, 2023
Merged
9 tasks
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Oct 6, 2023
@sayboras sayboras mentioned this pull request Oct 6, 2023
Merged
5 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.3 Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.3 Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.8 Oct 6, 2023
@sayboras sayboras mentioned this pull request Oct 6, 2023
Merged
5 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.15 Oct 6, 2023
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.15 Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport done to v1.12 in 1.12.15 Oct 6, 2023
@github-actions github-actions bot removed the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.13 in 1.13.8 Oct 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.12 in 1.12.15 Oct 6, 2023
@github-actions github-actions bot added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Oct 6, 2023
This was referenced Oct 17, 2023
Merged
Merged
@jrajahalme jrajahalme moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.3 Oct 18, 2023
@jrajahalme jrajahalme mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brlbil brlbil brlbil approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.12.15
Backport done to v1.12
1.14.3
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raphink @qmonnet @brlbil @sayboras